Remove references to io_bazel repository

[comius]

Users of @bazel_tools and bzlmod are broken when referring to the package that uses io_bazel.

[comius]

cc @Wyverald

[meteorcloudy]

I don't think @// will work correctly for Bzlmod, maybe we have to use Label("//third_party:javax_annotations") here? @Wyverald Can confirm.

[comius]

I tested this manually with rules_kotlin and it works.

[meteorcloudy]

How did you test with rules_kotlin? Does rules_kotlin somehow uses this macro?

Can you test if bazel build --enable_bzlmod //src:bazel_nojdk still work?

[comius]

How did you test with rules_kotlin? Does rules_kotlin somehow uses this macro?

I have a modded version of it. There's a dep in rules_kotlin, here https://github.com/bazelbuild/rules_kotlin/blob/master/src/main/protobuf/BUILD#L6-L14, that causes to load @bazel_tools//src/main/protobuf/BUILD, that causes to load @bazel_tools//third_party/grpc/build_defs.bzl.

Can you test if bazel build --enable_bzlmod //src:bazel_nojdk still work?

Argh, it fails:

ERROR: /usr/local/google/home/ilist/.cache/bazel/_bazel_ilist/e9eba874c4fa4205502c6d2768696dfb/external/googleapis~override/BUILD.bazel:76:18: no such package '@[unknown repo '' requested from @googleapis~override]//third_party/grpc-java': The repository '@[unknown repo '' requested from @googleapis~override]' could not be resolved: No repository visible as '@' from repository '@googleapis~override' and referenced by '@googleapis~override//:google_devtools_build_v1_publish_build_event_java_grpc'
ERROR: Analysis of target '//src:bazel_nojdk' failed; build aborted: 
INFO: Elapsed time: 18.611s

I'll check if I can fix it.

[meteorcloudy]

Yeah, I believe Label("//third_party:javax_annotations") will fix it since the label is resolved to the repo where the bzl file is located which is the same no matter where this macro is used.

[comius]

Main branch already fails with (maybe I'm doing something wrong):

$ bazel build  //src:bazel
$ bazel-bin/src/bazel build --enable_bzlmod //src:bazel_nojdk --keep_going
File "/usr/local/google/home/ilist/.cache/bazel/_bazel_ilist/e9eba874c4fa4205502c6d2768696dfb/external/grpc~1.47.0~grpc_repo_deps_ext~com_envoyproxy_protoc_gen_validate/bazel/protobuf.bzl", line 225, column 22, in <toplevel>
		Label("@com_google_re2j//jar"),

If I use Label this branch fails with the same errors building bazel_nojdk.

rules_kotlin work as before.

[meteorcloudy]

The main branch is getting fixed by #16578

[fmeum]

@bazel-io flag

[Wyverald]

@bazel-io fork 6.0.0

[sgowroji]

Hello @comius @Wyverald For Merging above Thirdparty change could you please squash the commits into one.

[comius]

Hello @comius @Wyverald For Merging above Thirdparty change could you please squash the commits into one.

@sgowroji done

[sgowroji]

Merged at 1d514ab