Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make bazel_cc_code_coverage_test more robust against GCC version diff… #16235

Closed

Conversation

c-mita
Copy link
Member

@c-mita c-mita commented Sep 7, 2022

…erences

  • -fprofile-dir shouldn't be used because on the g++ command line because it has different behaviour with different versions (w.r.t. where the output gcda file ends up).
  • The gcda and gcno files may end up in the same directory as the object file or in the current working directory.
  • The output of the gcov call in collect_cc_coverage may be ".gcda.gcov.json.gz" or ".gcov.json.gz" (as well as the original text file for much older GCC versions).

Also re-enable the test for Ubuntu 20.04 pre and postsubmits.

Fixes #16229

@ShreeM01 ShreeM01 added team-Rules-CPP Issues for C++ rules awaiting-review PR is awaiting review from an assigned reviewer labels Sep 7, 2022
@meteorcloudy
Copy link
Member

Hmm, looks like there are still some test failures

…erences

* -fprofile-dir shouldn't be used because on the g++ command line
  because it has different behaviour with different versions (w.r.t.
  where the output gcda file ends up).
* The gcda and gcno files may end up in the same directory as the object
  file or in the current working directory.
* The output of the gcov call in collect_cc_coverage may be
  "*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original
  text file for much older GCC versions).

Also re-enable the test for Ubuntu 20.04 pre and postsubmits.

Fixes bazelbuild#16229
@c-mita c-mita force-pushed the fix_collect_cc_coverage_test branch from d38c739 to 3cc009b Compare September 8, 2022 10:19
@c-mita
Copy link
Member Author

c-mita commented Sep 8, 2022

Hmm, looks like there are still some test failures

Fixed, I hope... ;)

Copy link
Contributor

@oquenchil oquenchil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@oquenchil oquenchil added awaiting-review PR is awaiting review from an assigned reviewer and removed awaiting-review PR is awaiting review from an assigned reviewer labels Sep 9, 2022
@copybara-service copybara-service bot closed this in 659b622 Sep 9, 2022
meteorcloudy pushed a commit to meteorcloudy/bazel that referenced this pull request Sep 12, 2022
…erences

* -fprofile-dir shouldn't be used because on the g++ command line because it
has different behaviour with different versions (w.r.t. where the output
gcda file ends up).
* The gcda and gcno files may end up in the same directory as the object file
or in the current working directory.
* The output of the gcov call in collect_cc_coverage may be
"*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file
for much older GCC versions).

Also re-enable the test for Ubuntu 20.04 pre and postsubmits.

Fixes bazelbuild#16229

Closes bazelbuild#16235.

PiperOrigin-RevId: 473218955
Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b
ShreeM01 pushed a commit that referenced this pull request Sep 12, 2022
…erences (#16254)

* -fprofile-dir shouldn't be used because on the g++ command line because it
has different behaviour with different versions (w.r.t. where the output
gcda file ends up).
* The gcda and gcno files may end up in the same directory as the object file
or in the current working directory.
* The output of the gcov call in collect_cc_coverage may be
"*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file
for much older GCC versions).

Also re-enable the test for Ubuntu 20.04 pre and postsubmits.

Fixes #16229

Closes #16235.

PiperOrigin-RevId: 473218955
Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b

Co-authored-by: Charles Mita <[email protected]>
@ShreeM01 ShreeM01 removed the awaiting-review PR is awaiting review from an assigned reviewer label Sep 15, 2022
aiuto pushed a commit to aiuto/bazel that referenced this pull request Oct 12, 2022
…erences

* -fprofile-dir shouldn't be used because on the g++ command line because it
has different behaviour with different versions (w.r.t. where the output
gcda file ends up).
* The gcda and gcno files may end up in the same directory as the object file
or in the current working directory.
* The output of the gcov call in collect_cc_coverage may be
"*.gcda.gcov.json.gz" or "*.gcov.json.gz" (as well as the original text file
for much older GCC versions).

Also re-enable the test for Ubuntu 20.04 pre and postsubmits.

Fixes bazelbuild#16229

Closes bazelbuild#16235.

PiperOrigin-RevId: 473218955
Change-Id: I1f4887f251da8f56f8ea525c1a1410e6257bf31b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
team-Rules-CPP Issues for C++ rules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

//src/test/shell/bazel:bazel_cc_code_coverage_test is failing in Bazel postsubmit
4 participants