Linux sandbox: ignore ENODEV when making the filesystem read-only. #16172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See e.g. https://github.com/systemd/systemd/blob/528ba54bbe3cf6c454985952d49e7a49ba62e244/src/core/automount.c#L556 and https://patchwork.kernel.org/project/linux-nfs/patch/[email protected]/#20551311 for background on automount and |
The code remounting existing mounts as read-only already ignores various errors, such as `EINVAL`, `ESTALE` etc. Unfortunately, it doesn't ignore `ENODEV`, which can occur in case of `autofs`/`automount` failure. Currently, having a single broken automount on the host can cause all sandboxes to fail with the following error: ``` src/main/tools/linux-sandbox-pid1.cc:281: "remount(nullptr, /data/foo, nullptr, 2101281, nullptr)": No such device ``` So simply also add `ENODEV` to the list of errors ignored.
cf-natali
force-pushed
the
linux-sandbox-enodev
branch
from
c030af2 to
cd19bec
Compare
sgowroji
added
team-Local-Exec
meisterT
approved these changes
Aug 30, 2022
ShreeM01
removed
the
awaiting-review
aiuto
pushed a commit
to aiuto/bazel
that referenced
this pull request
Oct 12, 2022
The code remounting existing mounts as read-only already ignores various errors, such as `EINVAL`, `ESTALE` etc. Unfortunately, it doesn't ignore `ENODEV`, which can occur in case of `autofs`/`automount` failure. Currently, having a single broken automount on the host can cause all sandboxes to fail with the following error: ``` src/main/tools/linux-sandbox-pid1.cc:281: "remount(nullptr, /data/foo, nullptr, 2101281, nullptr)": No such device ``` So simply also add `ENODEV` to the list of errors ignored. Closes bazelbuild#16172. PiperOrigin-RevId: 470953318 Change-Id: Ib737d94051fe7507a5e1f6fa01f367690429c47a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code remounting existing mounts as read-only already ignores various
errors, such as
EINVAL,ESTALEetc.Unfortunately, it doesn't ignore
ENODEV, which can occur in case ofautofs/automountfailure.Currently, having a single broken automount on the host can cause all
sandboxes to fail with the following error:
So simply also add
ENODEVto the list of errors ignored.