Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent aspects from executing on incompatible targets #15984

Commits on Jul 26, 2022

  1. Prevent aspects from executing on incompatible targets

    This patch prevents aspect functions from being evaluated when their
    associated targets are incompatible. Otherwise aspects can generate
    errors that should never be printed at all. For example, an aspect
    evaluating an incompatible target may generate errors about missing
    providers. This is not the desired behaviour.
    
    The implementation in this patch short-circuits the `AspectValue`
    creation if the associated target is incompatible.
    
    I had tried to add an `IncompatiblePlatformProvider` to the
    corresponding `ConfiguredAspect` instance, but then Bazel
    complained about having duplicate `IncompatiblePlatformProvider`
    instances.
    
    Fixes  bazelbuild#15271
    
    (cherry picked from commit 6d71850)
    philsc committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    3092328 View commit details
    Browse the repository at this point in the history
  2. Fix build and test

    philsc committed Jul 26, 2022
    Configuration menu
    Copy the full SHA
    2430961 View commit details
    Browse the repository at this point in the history

Commits on Jul 27, 2022

  1. Configuration menu
    Copy the full SHA
    cf123ef View commit details
    Browse the repository at this point in the history