Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Remote: Fix a bug that outputs of actions tagged with no-remote are u... #15453

Merged
merged 3 commits into from
May 27, 2022
Merged

[5.2] Remote: Fix a bug that outputs of actions tagged with no-remote are u... #15453

merged 3 commits into from
May 27, 2022

Commits on May 27, 2022

  1. Remote: Fix a bug that outputs of actions tagged with no-remote are u… 

    …ploaded to remote cache when remote execution is enabled.

Fixes bazelbuild#14900.

Also fixes an issue that action result from just remotely executed action is not saved to disk cache. The root cause is the action result is inlined in the execution response hence not downloaded through remote cache, hence not saved to disk cache. This results in the second build misses the disk cache, but it can still hit the remote cache and fill the disk cache. The third build can hit disk cache.

Closes bazelbuild#15212.

PiperOrigin-RevId: 441426469
    @coeuvre
    coeuvre committed May 27, 2022
    Configuration menu
    Copy the full SHA
    76ab07a View commit details
    Browse the repository at this point in the history

  2. Fix test

    @coeuvre
    coeuvre committed May 27, 2022
    Configuration menu
    Copy the full SHA
    80992d9 View commit details
    Browse the repository at this point in the history

  3. Merge branch 'release-5.2.0' into release-5.2.0

    @ckolli5
    ckolli5 authored May 27, 2022
    Configuration menu
    Copy the full SHA
    f8570b9 View commit details
    Browse the repository at this point in the history