Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(bzlmod): throw on json parse exception #15429

Merged
merged 1 commit into from
May 9, 2022
Merged

fix(bzlmod): throw on json parse exception #15429

merged 1 commit into from
May 9, 2022

Conversation

ckolli5
Copy link

@ckolli5 ckolli5 commented May 9, 2022

Fixes

Get rid of new lines in bazel_registry.json and return an Optional.empty() aka registry descriptor without mirrors and throw an IOException for malformed JSON to stick to official json.org specs

Closes #15109.

PiperOrigin-RevId: 436992309

@Tomsons @ckolli5
fix(bzlmod): throw on json parse exception
c6a815a 
[Fixes](#14437)

Get rid of new lines in `bazel_registry.json` and return an `Optional.empty()` aka registry descriptor without mirrors and throw an IOException for malformed JSON to stick to official json.org specs

Closes #15109.

PiperOrigin-RevId: 436992309
@ckolli5 ckolli5 merged commit 374400d into bazelbuild:release-5.2.0 May 9, 2022
@ckolli5 ckolli5 mentioned this pull request May 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckolli5 @Tomsons