Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.2] Fix checking remote cache for omitted files in buildevent file #15405

Merged
merged 1 commit into from
May 9, 2022
Merged

[5.2] Fix checking remote cache for omitted files in buildevent file #15405

merged 1 commit into from
May 9, 2022

Commits on May 5, 2022

  1. Fix checking remote cache for omitted files in buildevent file 

    Enabling both `--noremote_upload_local_results` and
`--incompatible_remote_build_event_upload_respect_no_cache` caused
ByteStreamBuildEventArtifactuploader not to check if some files already
existed remotely because local files were not to be uploaded. When using
remote execution some of these files might exist remotely, so we want to
check remote cache for those files even if we would not upload them if
missing. The test case included depicts this failure case.

Closes bazelbuild#15280.

PiperOrigin-RevId: 442798312
(cherry picked from commit 317375d)
    @exoson @brentleyjones
    exoson authored and brentleyjones committed May 5, 2022
    Configuration menu
    Copy the full SHA
    3d5cde6 View commit details
    Browse the repository at this point in the history