Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.1] Adding Starlark dependencies to the package //external #14991

Merged
merged 2 commits into from
Mar 8, 2022
Merged

[5.1] Adding Starlark dependencies to the package //external #14991

merged 2 commits into from
Mar 8, 2022

Commits on Mar 7, 2022

  1. Adding Starlark dependencies to the package //external 

    This is an alternative approach to fix bazelbuild#14280. It adds transitive closure of Starlark dependencies to `//external` package when loading `WORKSPACE` file, so it can be processed in the same way as `BUILD` files during query execution. Comparing to the approach taken in bazelbuild#14497, this approach is less intrusive, but not able to distinguish the extension files needed by `//external:foo` and `//external:bar`, meaning `buildfiles(//external:foo)` returns the same result as `buildfiles(//external:*)`. However, this behavior is consistent with other packages. For example, `buildfiles(//foo:bar)` has the same result as `buildfiles(//foo:*)`.

Closes bazelbuild#14630.

PiperOrigin-RevId: 424092916
(cherry picked from commit a6c3f23)
    @linzhp @brentleyjones
    linzhp authored and brentleyjones committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    52442ad View commit details
    Browse the repository at this point in the history

  2. Avoid bazel_module_test timeout on macos 

    https://buildkite.com/bazel/bazel-bazel/builds/17785#9a1fb564-c6f9-4e69-ac8f-87c422a002b0
By setting the test size to "large".

RELNOTES:None
PiperOrigin-RevId: 409114345
(cherry picked from commit 1d99391)
    @meteorcloudy @brentleyjones
    meteorcloudy authored and brentleyjones committed Mar 7, 2022
    Configuration menu
    Copy the full SHA
    82e9efa View commit details
    Browse the repository at this point in the history