Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Normalize rpath entries to guard against missing default solib dir #14924

Closed
wants to merge 1 commit into from
Closed

Normalize rpath entries to guard against missing default solib dir #14924

wants to merge 1 commit into from

Commits on Mar 1, 2022

  1. Normalize rpath entries to guard against missing default solib dir 

    When all dynamic deps in a build are built in transitioned configurations, the default solib dir is not created. However, while
resolving paths, the dynamic linker stops at the first directory that does not exist, even when followed by `../`.

Before this commit, all rpath entries would consist of the relative path to the default solib dir followed by the relative path to the
particular library's solib dir. Thus, if the default solib dir was missing, the dynamic linker wouldn't resolve any of these paths.

This commit ensures that the relative path entries are normalized and thus contain no references to non-existing directories assuming the normalized path itself exists.

Work towards bazelbuild#13819.

Closes bazelbuild#14660.

PiperOrigin-RevId: 431671888
    @fmeum
    fmeum committed Mar 1, 2022
    Configuration menu
    Copy the full SHA
    386269d View commit details
    Browse the repository at this point in the history