Fix file counting in merkletree.DirectoryTreeBuilder #14299
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed. The error was visible when adding a file and the directory containing that file as inputs for an action. Fixes bazelbuild#14286.
|
@brentleyjones Are you able to try this patch on your internal test case? It fixes my minimal case of the empty file |
|
@moroten This fixes our internal test case. |
|
cc @coeuvre |
|
ping @coeuvre |
meteorcloudy
pushed a commit
to meteorcloudy/bazel
that referenced
this pull request
Nov 25, 2021
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed. The error was visible when adding a file and the directory containing that file as inputs for an action. Fixes bazelbuild#14286. Closes bazelbuild#14299. PiperOrigin-RevId: 412051374
coeuvre
pushed a commit
to coeuvre/bazel
that referenced
this pull request
Nov 25, 2021
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed. The error was visible when adding a file and the directory containing that file as inputs for an action. Fixes bazelbuild#14286. Closes bazelbuild#14299. PiperOrigin-RevId: 412051374
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 25, 2021
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed. The error was visible when adding a file and the directory containing that file as inputs for an action. Fixes #14286. Closes #14299. PiperOrigin-RevId: 412051374 Co-authored-by: Fredrik Medley <[email protected]>
Bencodes
pushed a commit
to Bencodes/bazel
that referenced
this pull request
Jan 10, 2022
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed. The error was visible when adding a file and the directory containing that file as inputs for an action. Fixes bazelbuild#14286. Closes bazelbuild#14299. PiperOrigin-RevId: 412051374
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The DirectoryTreeBuilder did not check if files already existed in the resulting map, so the file counter got wrong and an assertion failed.
The error was visible when adding a file and the directory containing that file as inputs for an action.
Fixes #14286.