Format work requests according to ndjson spec #14219
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfd
force-pushed
the
danny/ndjson-workers
branch
from
91df9fb
to
9aaca96
Compare
keith
approved these changes
Nov 2, 2021
|
awesome thanks for doing this! |
|
Nice! Could you fix the tests, too? |
|
Alright, tests have been updated! |
keith
approved these changes
Nov 4, 2021
|
@larsrc-google have you had a chance to take a look at this? |
larsrc-google
approved these changes
Nov 22, 2021
|
Sorry about the delay, I need to update my mail filters. This looks fine. |
wolfd
added a commit
to wolfd/bazel
that referenced
this pull request
Nov 23, 2021
JSON persistent workers now delimit requests with newlines (`\n` on Unix, `\r\n` on Windows). Fixes bazelbuild#14218. Closes bazelbuild#14219. PiperOrigin-RevId: 411596359
meteorcloudy
pushed a commit
that referenced
this pull request
Nov 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JSON persistent workers now delimit requests with newlines (
\non Unix,\r\non Windows).Fixes #14218.