Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remote-execution-caching-debug.md #14099

Closed
wants to merge 1 commit into from

Conversation

ecngtng
Copy link
Contributor

@ecngtng ecngtng commented Oct 12, 2021

  1. When '--execution_log_json_file' is used, we don't need to download code and use execution log parser to convert the logs to
    text anymore. We could directly use our favourite text differ to diff.
    This option is more convenient than '--execution_log_binary_file'.

  2. Add information about 'internal' and update example with that.

When '--execution_log_json_file' is used, we don't need to download code and use execution log parser to convert the logs to text anymore.
This option is more convenient than '--execution_log_binary_file'.

Add information about 'internal' and update example with that.
@google-cla
Copy link

google-cla bot commented Oct 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no label Oct 12, 2021
@ecngtng
Copy link
Contributor Author

ecngtng commented Oct 12, 2021 via email

@google-cla
Copy link

google-cla bot commented Oct 12, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@ecngtng
Copy link
Contributor Author

ecngtng commented Oct 12, 2021 via email

@google-cla google-cla bot added cla: yes and removed cla: no labels Oct 12, 2021
@ulrfa
Copy link
Contributor

ulrfa commented Oct 13, 2021

Note that this PR resolves: #8359

@ecngtng ecngtng marked this pull request as ready for review October 13, 2021 09:32
@brentleyjones
Copy link
Contributor

By using src/tools/execlog:parser, the order of the actions are synced. Is the json output ordered in a way that diffing is easy, or does it need to be post-processed?

@ulrfa
Copy link
Contributor

ulrfa commented Oct 13, 2021

By using src/tools/execlog:parser, the order of the actions are synced. Is the json output ordered in a way that diffing is easy, or does it need to be post-processed?

The json file produced by --execution_log_json_file is sorted, so no post-processing is needed before textual comparison.

@aiuto aiuto added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label Oct 14, 2021
@aiuto aiuto requested review from coeuvre and removed request for jin, aiuto, gregestren and floriographygoth October 14, 2021 03:55
@bazel-io bazel-io closed this in b35944e Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants