Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remote: Register "remote" strategy even if remote execution is not available. #13490

Closed

Conversation

coeuvre
Copy link
Member

@coeuvre coeuvre commented May 19, 2021

So that you can set a --spawn_strategy that includes remote without setting --remote_executor. In addition, if --remote_local_fallback is set and remote_executor is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes #13340 and #13487.

@google-cla google-cla bot added the cla: yes label May 19, 2021
@coeuvre coeuvre force-pushed the remote-strategy-placeholder branch from 90f3ece to 2d3ca7f Compare May 20, 2021 05:52
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without set `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.
@coeuvre coeuvre force-pushed the remote-strategy-placeholder branch from a4c2b64 to 7207586 Compare May 20, 2021 07:03
@coeuvre coeuvre marked this pull request as ready for review May 20, 2021 07:03
@coeuvre coeuvre requested a review from philwo May 20, 2021 07:03
@coeuvre coeuvre added the team-Remote-Exec Issues and PRs for the Execution (Remote) team label May 20, 2021
@coeuvre coeuvre self-assigned this May 20, 2021
@bazel-io bazel-io closed this in 7643d3a Jun 9, 2021
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jul 15, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
coeuvre added a commit to coeuvre/bazel that referenced this pull request Jul 16, 2021
…ailable.

So that you can set a `--spawn_strategy` that includes `remote` without setting `--remote_executor`. In addition, if `--remote_local_fallback` is set and `remote_executor` is unreachable when build starts, Bazel will fallback to next available strategy.

Fixes bazelbuild#13340 and bazelbuild#13487.

Closes bazelbuild#13490.

PiperOrigin-RevId: 378339904
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes team-Remote-Exec Issues and PRs for the Execution (Remote) team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should be allowed to set remote --spawn_strategy without remote_executor set
2 participants