Remove wrapped_clang params files after use #12896
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use TempFile's destructor to remove the params file. Because we previously exec'd a new process, this was never called. Now we run them as subprocesses so we can cleanup afterwards.
|
@oquenchil can you review? |
|
@oquenchil thanks, can you help land this? |
philwo
pushed a commit
that referenced
this pull request
Apr 20, 2021
We use TempFile's destructor to remove the params file. Because we previously exec'd a new process, this was never called. Now we run them as subprocesses so we can cleanup afterwards. Closes #12896. PiperOrigin-RevId: 366211823
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use TempFile's destructor to remove the params file. Because we
previously exec'd a new process, this was never called. Now we run
them as subprocesses so we can cleanup afterwards.