Fix the classic query package-loading cutoff optimization with external workspaces. #12595
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jin
added
team-Core
|
Reassigned to @meisterT for further triage since this is |
|
Are there a lot of internal tests for query? |
|
I assumed you would add the test here: https://github.com/bazelbuild/bazel/blob/master/src/test/shell/integration/bazel_query_test.sh |
|
I can do that. Normally, I make some effort to not write shell integration tests, though, since bash is not a very good programming language. |
benjaminp
force-pushed
the
query-loading
branch
from
30ef3d5
to
43ceefb
Compare
…al workspaces. A package's path fragment is not unambiguous when external workspaces are involved. Fixes bazelbuild#12497.
benjaminp
force-pushed
the
query-loading
branch
from
43ceefb
to
482d24a
Compare
meisterT
approved these changes
Dec 7, 2020
ulfjack
pushed a commit
to EngFlow/bazel
that referenced
this pull request
Mar 5, 2021
…al workspaces. A package's path fragment is not unambiguous when external workspaces are involved. Fixes bazelbuild#12497. Closes bazelbuild#12595. PiperOrigin-RevId: 346048937
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A package's path fragment is not unambiguous when external workspaces are involved.
Fixes #12497.