Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add attr.string_keyed_label_dict? #5356

Closed
ash2k opened this issue Jun 8, 2018 · 2 comments
Closed

Add attr.string_keyed_label_dict? #5356

ash2k opened this issue Jun 8, 2018 · 2 comments
Assignees
@laurentlb
Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request

Comments

@ash2k
Copy link
Contributor

ash2k commented Jun 8, 2018

Description of the problem / feature request:

I have a rule that does templating. I use label_keyed_string_dict and it is ok, but what if I want several strings to be replaced with the same label's output? string_keyed_label_dict would be useful (+ #5355).
@excitoon
Copy link
Contributor

excitoon commented Jun 9, 2018

Basically, label_list is enough to make everything. One can pass this dict as a list of labels plus a list of string and zip it inside the rule. This approach have an issue though, because label_list cannot contain the same labels, but it can be worked around by one more list of indices to smaller label_list.

@mboes mboes mentioned this issue Sep 19, 2018
Merged
@laurentlb laurentlb added P3 We're not considering working on this, but happy to review a PR. (No assignee) team-Starlark and removed category: extensibility > skylark labels Nov 21, 2018
thufschmitt added a commit to tweag/rules_nixpkgs that referenced this issue Jan 14, 2019
@thufschmitt
chore: Add invert_repositories function
610a8da 
Generic function for working around
bazelbuild/bazel#5356
thufschmitt added a commit to tweag/rules_nixpkgs that referenced this issue Jan 14, 2019
@thufschmitt
chore: Add invert_repositories function
570f1d1 
Generic function for working around
bazelbuild/bazel#5356
Profpatsch pushed a commit to tweag/rules_nixpkgs that referenced this issue Feb 18, 2019
@thufschmitt @Profpatsch
chore: Add invert_repositories function
85a1a58 
Generic function for working around
bazelbuild/bazel#5356
@mboes
Copy link
Contributor

mboes commented May 30, 2019

This and #7989 are duplicates of each oher.

flokli added a commit to flokli/rules_nixpkgs that referenced this issue Sep 18, 2019
@flokli
nixpkgs.bzl: update link to issue
4dc50d0 
bazelbuild/bazel#5356 and
bazelbuild/bazel#7989, are duplicates, and the
former was closed. So let's link to the latter instead.
@flokli flokli mentioned this issue Sep 18, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@laurentlb laurentlb

Labels
P3 We're not considering working on this, but happy to review a PR. (No assignee) type: feature request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@mboes @ash2k @laurentlb @excitoon @laszlocsomor