Upgrade grpc and abseil-cpp version #22719
Assignees
Labels
P1
I'll work on this now. (Assignee required)
team-ExternalDeps
External dependency handling, remote repositiories, WORKSPACE file.
type: feature request
Comments
meteorcloudy
added
type: feature request
P2
copybara-service bot
pushed a commit
that referenced
this issue
Aug 9, 2024
* Prefer `absl::flat_hash_map` to `std::unordered_map`. This is a much more efficient data structure. * Prefer `absl::string_view` to `const char*`. This allows compile-time strlen. * Prefer `absl::WrapUnique` to `std::unique_ptr<T>(T*)`. This better signals intent to wrap a raw pointer. * Prefer `std::vector` to `std::deque` given we only need a stack, not a queue. This is much faster and more memory-efficient. * Use if-init to more tightly scope variables. * Prefer `absl::StrCat` to `blaze_util::StringPrintf` in simple cases. This is faster and more readable when merely concatenating a few strings together. * Prefer `absl::StrFormat` to `blaze_util::StringPrintf` in cases where we need to do more complicated string construction. This is the standard printf-style library in Google. * Prefer `absl::StrAppend` to `std::string::operator+`. This is more efficient and readable. * Prefer `absl::StrSplit` to `blaze_util::Split`. This is the standard string splitting library in Google. * Prefer `absl::StartsWith` to `std::string::compare`. This is a more expressive API. * Prefer `absl::c_linear_search` to `std::find`. This avoids needing to name the container three times. This should really be `absl::c_contains`, which provides a better name to the operation, but this is blocked by #22719. * Use the early-return pattern where possible to decrease nesting. * Use references to remove unnecessary copies. * Don't store unnecessary variables in the class. This decreases object size. * Remove using-declarations for names in `std::`, which is discouraged. PiperOrigin-RevId: 661149102 Change-Id: I2ab8fc617e1cec9f6bb81c6a3d5bbb883164f299
meteorcloudy
added
P1
This was referenced Sep 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Follow up on #22692 (comment)
An experimental upgrade has been blocked on googleapis (which is currently vendored and doesn't match the source repo structure): meteorcloudy@ffc2439
The text was updated successfully, but these errors were encountered: