Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repository rules should not re-fetch when .netrc changes #22118

Closed
mortenmj opened this issue Apr 25, 2024 · 1 comment
Closed

Repository rules should not re-fetch when .netrc changes #22118

mortenmj opened this issue Apr 25, 2024 · 1 comment
Assignees
Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request

Comments

@mortenmj
Copy link

Description of the feature request:

The http_archive/file/jar rules read the user's .netrc file in order to authenticate, as of 7.1.0. Presumably as a consequence of this, the netrc file appears in external repo marker files. This means that changes to the netrc file cause re-fetching of these dependencies.

Which category does this issue belong to?

External Dependency

What underlying problem are you trying to solve with this feature?

Changes to .netrc should not cause re-fetching of external dependencies that have been successfully fetched.

Which operating system are you running Bazel on?

Linux

What is the output of bazel info release?

release 7.1.1

If bazel info release returns development version or (@non-git), tell us how you built Bazel.

No response

What's the output of git remote get-url origin; git rev-parse HEAD ?

No response

Have you found anything relevant by searching the web?

No response

Any other information, logs, or outputs that you want to share?

No response

@github-actions github-actions bot added the team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. label Apr 25, 2024
@fmeum fmeum added P1 I'll work on this now. (Assignee required) and removed untriaged labels Apr 25, 2024
@fmeum fmeum assigned fmeum and unassigned sgowroji, iancha1992 and satyanandak Apr 25, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Apr 29, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Apr 29, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
github-merge-queue bot pushed a commit that referenced this issue Apr 30, 2024
Modifying auth information should not result in a repo rule being
reevaluated after a successful evaluation. This regressed in
a5376aa.

Fixes #22118

Closes #22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc

Commit
3fc76be

Co-authored-by: Fabian Meumertzheim <[email protected]>
Wyverald pushed a commit that referenced this issue May 6, 2024
Modifying auth information should not result in a repo rule being
reevaluated after a successful evaluation. This regressed in
a5376aa.

Fixes #22118

Closes #22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc

Commit
3fc76be

Co-authored-by: Fabian Meumertzheim <[email protected]>
@iancha1992
Copy link
Member

A fix for this issue has been included in Bazel 7.1.2 RC1. Please test out the release candidate and report any issues as soon as possible.
If you're using Bazelisk, you can point to the latest RC by setting USE_BAZEL_VERSION=7.1.2rc1. Thanks!

Kila2 pushed a commit to Kila2/bazel that referenced this issue May 13, 2024
Modifying auth information should not result in a repo rule being reevaluated after a successful evaluation. This regressed in a5376aa.

Fixes bazelbuild#22118

Closes bazelbuild#22125.

PiperOrigin-RevId: 629182408
Change-Id: I0c553e9ded72230b647a37203d51ba779976d7fc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 I'll work on this now. (Assignee required) team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. type: feature request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants