Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

starlark_repository_test is failling with Bazel@HEAD #20790

Closed
sgowroji opened this issue Jan 8, 2024 · 3 comments
Closed

starlark_repository_test is failling with Bazel@HEAD #20790

sgowroji opened this issue Jan 8, 2024 · 3 comments
Labels
flaky test P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug

Comments

@sgowroji
Copy link
Member

sgowroji commented Jan 8, 2024 •
edited
Loading

CI: https://buildkite.com/bazel/bazel-at-head-plus-downstream/builds/3577#018ce8de-917e-4943-82b5-5d4e4ba930e0

Platform: Ubuntu

Logs:

//src/test/shell/bazel:starlark_repository_test                          FAILED in 3 out of 8 in 157.2s

CC Greenteam @fweikert
@sgowroji sgowroji added type: bug untriaged team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website labels Jan 8, 2024
@Wyverald
Copy link
Member

Wyverald commented Jan 8, 2024

This one has been flaky for a while, I think.

@Wyverald
Copy link
Member

Wyverald commented Jan 8, 2024 •
edited
Loading

test analytics link: test_disable_download_should_prevent_downloading and test_starlark_headers_override_default_headers

The two test cases above are by far the worst offenders. The failure has been observed on all Linux platforms (CentOS & the various Ubuntus), but never on macOS.

@Wyverald Wyverald mentioned this issue Jan 8, 2024
Closed
@Wyverald
Copy link
Member

Wyverald commented Jan 9, 2024

Found a failure on macOS too -- https://buildkite.com/bazel/bazel-bazel/builds/26163#018ceb78-abeb-4b5e-8420-7b4cd05ddee7

@meteorcloudy meteorcloudy added flaky test P2 We'll consider working on this in future. (Assignee optional) and removed untriaged labels Jan 10, 2024
bazel-io pushed a commit to bazel-io/bazel that referenced this issue Feb 12, 2024
@meteorcloudy @bazel-io
Fix flakiness in //src/test/shell/bazel:starlark_repository_test
dbc367a 
Make sure repository cache is not used by adding --repository_cache= to bazelrc

https://buildkite.com/bazel/bazel-bazel/builds/26360#018d21bc-b66f-4f99-98af-de50fc10794f

Fixes bazelbuild#20790

PiperOrigin-RevId: 599872040
Change-Id: I8203d15a8826431f5eb4de9dc33894dc5be21936
@bazel-io bazel-io mentioned this issue Feb 12, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Feb 12, 2024
@bazel-io @meteorcloudy
[7.1.0] Fix flakiness in //src/test/shell/bazel:starlark_repository_t…
39b614b 
…est (#21309)

Make sure repository cache is not used by adding --repository_cache= to
bazelrc


https://buildkite.com/bazel/bazel-bazel/builds/26360#018d21bc-b66f-4f99-98af-de50fc10794f

Fixes #20790

Commit
83b825f

PiperOrigin-RevId: 599872040
Change-Id: I8203d15a8826431f5eb4de9dc33894dc5be21936

Co-authored-by: Googler <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
flaky test P2 We'll consider working on this in future. (Assignee optional) team-OSS Issues for the Bazel OSS team: installation, release processBazel packaging, website type: bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Wyverald @meteorcloudy @sgowroji