Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

//src/test/shell/bazel:jdeps_test failing on RBE #20288

Closed
meteorcloudy opened this issue Nov 22, 2023 · 5 comments
Closed

//src/test/shell/bazel:jdeps_test failing on RBE #20288

meteorcloudy opened this issue Nov 22, 2023 · 5 comments
Labels
breakage P0 This is an emergency and more important than other current work. (Assignee required) team-Rules-Java Issues for Java rules type: bug untriaged

Comments

@meteorcloudy
Copy link
Member

meteorcloudy commented Nov 22, 2023 •
edited
Loading

The following error is only happening on RBE Linux platform.

--- /b/f/w/bazel-out/k8-fastbuild/bin/src/test/shell/bazel/jdeps_test.runfiles/_main/src/jdeps_modules.golden	2023-11-22 09:54:06.245590291 +0000
+++ jdeps-sorted	2023-11-22 09:55:22.346087882 +0000
@@ -2,7 +2,6 @@
 java.compiler
 java.instrument
 java.logging
-java.management
 java.naming
 java.sql
 java.xml

First broken RBE build in postsubmit: https://buildkite.com/bazel/bazel-bazel/builds/25696#018bf414-616b-4833-ba41-7b21d22f62ee

Suspected culprit: 91ad91d

This is currently blocking Bazel presubmit: https://buildkite.com/bazel/google-bazel-presubmit/builds/74116
@meteorcloudy meteorcloudy added type: bug P0 This is an emergency and more important than other current work. (Assignee required) breakage team-Rules-Java Issues for Java rules labels Nov 22, 2023
@meteorcloudy
Copy link
Member Author

I'm disabling this test on RBE to unblock presubmit.

@meteorcloudy
Copy link
Member Author

@hvadehra @cushon Can you please help check what's going on?

copybara-service bot pushed a commit that referenced this issue Nov 22, 2023
@meteorcloudy @copybara-github
Disable //src/test/shell/bazel:jdeps_test on RBE build to fix presubmit
01f6205 
Related #20288

PiperOrigin-RevId: 584584636
Change-Id: Iea064efe8d6caf9e60daf32e5408c325524685ca
Wyverald pushed a commit that referenced this issue Jan 3, 2024
@meteorcloudy @Wyverald
Disable //src/test/shell/bazel:jdeps_test on RBE build to fix presubmit
b652cdf 
Related #20288

PiperOrigin-RevId: 584584636
Change-Id: Iea064efe8d6caf9e60daf32e5408c325524685ca
Wyverald pushed a commit that referenced this issue Jan 3, 2024
@hvadehra @Wyverald
Automated rollback of commit 01f6205.
9a0bffb 
*** Reason for rollback ***

Fix jdeps_test RBE failure

The culprit change added a new class that presumably pushed us over the xargs arg limit. Unfortunately, jdeps does not support @argfile, so this change updates the command buffer size to twice the default on RBE.

Fixes #20288

*** Original change description ***

Disable //src/test/shell/bazel:jdeps_test on RBE build to fix presubmit

Related #20288

PiperOrigin-RevId: 584820138
Change-Id: I6f5157d7e72c539a5fdc81841a35543df473aa4a
@hvadehra hvadehra mentioned this issue Jun 20, 2024
Merged
@fmeum
Copy link
Collaborator

fmeum commented Jun 20, 2024

@bazel-io fork 7.2.1

@fmeum
Copy link
Collaborator

fmeum commented Jun 20, 2024

@bazel-io fork 7.3.0

This was referenced Jun 20, 2024
Closed
Closed
@fmeum
Copy link
Collaborator

fmeum commented Jun 20, 2024

Nvm, this has already been cherry-picked. We may need to bump the limit again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
breakage P0 This is an emergency and more important than other current work. (Assignee required) team-Rules-Java Issues for Java rules type: bug untriaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@meteorcloudy @fmeum