Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

--incompatible_remote_results_ignore_disk + --disk_cache makes --incompatible_remote_build_event_upload_respect_no_cache not work #14463

Closed
brentleyjones opened this issue Dec 21, 2021 · 1 comment

Comments

@brentleyjones
Copy link
Contributor

brentleyjones commented Dec 21, 2021

Description of the problem / feature request:

When using --incompatible_remote_results_ignore_disk + --disk_cache, --incompatible_remote_build_event_upload_respect_no_cache no longer prevents uploads to BES.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

This will exclude blobs from upload:

$ git clone [email protected]:bazelbuild/rules_apple.git
$ cd rules_apple
$ env USE_BAZEL_VERSION=3ea70282c5795670070d8cb546cac8aa321d79ce bazelisk build --remote_cache=grpcs://remote.buildbuddy.io --bes_backend=grpcs://remote.buildbuddy.io --bes_results_url=https://app.buildbuddy.io/invocation/ --incompatible_remote_build_event_upload_respect_no_cache --noremote_upload_local_results --disk_cache=/tmp/bazel_disk_cache //examples/iOS/StickersApp

While this won't:

$ env USE_BAZEL_VERSION=3ea70282c5795670070d8cb546cac8aa321d79ce bazelisk build --remote_cache=grpcs://remote.buildbuddy.io --bes_backend=grpcs://remote.buildbuddy.io --bes_results_url=https://app.buildbuddy.io/invocation/ --incompatible_remote_build_event_upload_respect_no_cache --noremote_upload_local_results --disk_cache=/tmp/bazel_disk_cache --incompatible_remote_results_ignore_disk //examples/iOS/StickersApp

What operating system are you running Bazel on?

macOS 12.0.1

What's the output of bazel info release?

Bazel built from HEAD to have #14451 in it.

Have you found anything relevant by searching the web?

#14338

@brentleyjones
Copy link
Contributor Author

cc @coeuvre

coeuvre added a commit to coeuvre/bazel that referenced this issue Dec 23, 2021
…e working with --incompatible_remote_results_ignore_disk.

Fixes bazelbuild#14463.

Closes bazelbuild#14468.

PiperOrigin-RevId: 417984062
Wyverald pushed a commit that referenced this issue Dec 23, 2021
* Remote: Don't upload BES referenced blobs to disk cache.

Fixes #14435.

Closes #14451.

PiperOrigin-RevId: 417629899

* Remote: Make `--incompatible_remote_build_event_upload_respect_no_cache` working with alias.

Fixes #14456.

Closes #14461.

PiperOrigin-RevId: 417637635

* Remote: Make --incompatible_remote_build_event_upload_respect_no_cache working with --incompatible_remote_results_ignore_disk.

Fixes #14463.

Closes #14468.

PiperOrigin-RevId: 417984062
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant