Skip to content

Commit

Permalink
Flip incompatible_disallow_resource_jars flag.
Browse files Browse the repository at this point in the history 
The resource_jars is not supported by java_common.compile function. In
order to rewrite java_library to Starlark the call needs to be extended or the
feature disabled. Because the migration is relatively simple I'm opting
to flip the flag and remove it.

RELNOTES[INC]: Flipped --incompatible_disallow_resource_jars (see #13221).

Closes #13891.

PiperOrigin-RevId: 392427418
  • Loading branch information
@comius @copybara-github
comius authored and copybara-github committed Aug 23, 2021
1 parent 2945ef5 commit fec2fdb
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/main/java/com/google/devtools/build/lib/rules/java/JavaOptions.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -477,7 +477,7 @@ public ImportDepsCheckingLevelConverter() {

@Option(
name = "incompatible_disallow_resource_jars",
defaultValue = "false",
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.UNDOCUMENTED,
effectTags = {OptionEffectTag.UNKNOWN},
metadataTags = {
Expand Down

2 comments on commit fec2fdb

@Leyart
Copy link

@Leyart Leyart commented on fec2fdb Sep 21, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will resource_jars be removed permanently in 5.0 from java_library? I am asking because we will have to refactor a couple of rules due to this change and since we are migrating to Bazel know, better to do it earlier than later

@comius
Copy link
Contributor Author

@comius comius commented on fec2fdb Sep 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated documentation on the issue #13221. We intend to permanently remove resource_jars after 5.0 release, meaning that in 5.0 you will be still able to flip it back, but not in later releases or in rolling releases.

Please sign in to comment.