Skip to content

Commit

Permalink
Offer Shell completion for top-level packages without subpackages
Browse files Browse the repository at this point in the history
`bazel build //` now completes to `bazel build //:` when there are no packages beneath the top-level package. While this is mostly an edge case that doesn't apply to real projects, it will become more relevant when completion support is added for external repositories in a future PR.

Closes #20679.

PiperOrigin-RevId: 597873995
Change-Id: Ida2b26536325acf130a9792b915ed8f3fe425a24
  • Loading branch information
fmeum authored and copybara-github committed Jan 12, 2024
1 parent 63e5f41 commit ad3dd45
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 0 deletions.
15 changes: 15 additions & 0 deletions scripts/bash_completion_test.sh
Original file line number Diff line number Diff line change
Expand Up @@ -794,4 +794,19 @@ test_workspace_boundary() {
'build //sub_repo/'
}

test_complete_root_package() {
# This test only works for Bazel
if [[ ! " ${COMMAND_ALIASES[*]} " =~ " bazel " ]]; then return; fi

mkdir pkgs_repo
touch pkgs_repo/WORKSPACE
cat > pkgs_repo/BUILD <<'EOF'
cc_binary(name = "main")
EOF
cd pkgs_repo 2>/dev/null

assert_expansion 'build //' \
'build //:'
}

run_suite "Tests of bash completion of 'blaze' command."
8 changes: 8 additions & 0 deletions scripts/bazel-complete-template.bash
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,14 @@ _bazel__expand_package_name() {
fi
fi
done
# The loop over the compgen -d output above does not include the top-level
# package.
if [ -f $root$current/BUILD.bazel -o -f $root$current/BUILD ]; then
found=1
if [ "${type}" != "label-package" ]; then
echo "${current}:"
fi
fi
[ $found -gt 0 ] && break # Stop searching package path upon first match.
done
}
Expand Down

0 comments on commit ad3dd45

Please sign in to comment.