devtools/build/lib/rules/cpp: add iverilog shared library extensions

PiperOrigin-RevId: 576803923 Change-Id: Iaa8e3e70bbcc7c4294650aa186defa2da3361bea
bazelbuild · Oct 26, 2023 · 781633c · 781633c
1 parent 8630b01
commit 781633c
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java b/src/main/java/com/google/devtools/build/lib/rules/cpp/CppFileTypes.java
@@ -249,7 +249,7 @@ public ImmutableList<String> getExtensions() {
   // TODO(bazel-team): File types should not be read from this hard-coded list but should come from
   // the toolchain instead. See https://github.com/bazelbuild/bazel/issues/17117
   public static final FileType SHARED_LIBRARY =
-      FileType.of(".so", ".dylib", ".dll", ".pyd", ".wasm");
+      FileType.of(".so", ".dylib", ".dll", ".pyd", ".wasm", ".tgt", ".vpi");
   // Unix shared libraries can be passed to linker, but not .dll on Windows
   public static final FileType UNIX_SHARED_LIBRARY = FileType.of(".so", ".dylib");
   public static final FileType INTERFACE_SHARED_LIBRARY =

diff --git a/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java b/src/test/java/com/google/devtools/build/lib/rules/cpp/StarlarkCcCommonTest.java
@@ -5301,12 +5301,13 @@ public void testWrongExtensionThrowsError() throws Exception {
     assertThat(e)
         .hasMessageThat()
         .contains(
-            "'a.ifso' does not have any of the allowed extensions .so, .dylib, .dll, .pyd or"
-                + " .wasm");
+            "'a.ifso' does not have any of the allowed extensions .so, .dylib, .dll, .pyd, .wasm,"
+                + " .tgt or .vpi");
     assertThat(e)
         .hasMessageThat()
         .contains(
-            "'a.lib' does not have any of the allowed extensions .so, .dylib, .dll, .pyd or .wasm");
+            "'a.lib' does not have any of the allowed extensions .so, .dylib, .dll, .pyd, .wasm,"
+                + " .tgt or .vpi");
     assertThat(e)
         .hasMessageThat()
         .contains(