Fix some broken targets and failing tests.

RELNOTES: None PiperOrigin-RevId: 178099410
bazelbuild · Dec 6, 2017 · 68c577a · 68c577a
1 parent 16059b3
commit 68c577a
Show file tree

Hide file tree

Showing 6 changed files with 12 additions and 4 deletions.
diff --git a/src/test/java/com/google/devtools/build/lib/BUILD b/src/test/java/com/google/devtools/build/lib/BUILD
@@ -1,5 +1,8 @@
 package(
-    default_visibility = ["//src/test/java/com/google/devtools/build/lib:__subpackages__"],
+    default_visibility = [
+        "//src/test/java/com/google/devtools/build/lib:__subpackages__",
+        "//tools/test:__pkg__",
+    ],
 )
 
 # Tests for Windows-specific functionality that can run cross-platform.

diff --git a/src/tools/runfiles/runfiles_posix_test.sh b/src/tools/runfiles/runfiles_posix_test.sh
diff --git a/tools/build_defs/pkg/BUILD b/tools/build_defs/pkg/BUILD
@@ -32,6 +32,8 @@ py_test(
     ],
     data = [":archive_testdata"],
     srcs_version = "PY2AND3",
+    # archive.py requires xzcat, which is not available by default on Mac
+    tags = ["noci"],
     deps = [":archive"],
 )
 
@@ -216,6 +218,8 @@ sh_test(
         ":test-tar-xz.tar.xz",
         ":titi_test_all.changes",
     ],
+    # archive.py requires xzcat, which is not available by default on Mac
+    tags = ["noci"],
     deps = [
         "//src/test/shell:bashunit",
     ],

diff --git a/tools/osx/xcode_version_flag.bzl b/tools/osx/xcode_version_flag.bzl
@@ -81,7 +81,7 @@ def _macos_sdk_version_flag_impl(ctx):
   return struct(providers = [
       config_common.FeatureFlagInfo(value = _strip_version(
           xcode_config.sdk_version_for_platform(
-              apple_common.platform.macos_device)))])
+              apple_common.platform.macos)))])
 
 
 xcode_version_flag = rule(

diff --git a/tools/test/BUILD b/tools/test/BUILD
@@ -24,6 +24,7 @@ java_test(
     deps = [
         ":LcovMergerTestUtils",
         "//src/main/java/com/google/devtools/build/lib/vfs",
+        "//src/test/java/com/google/devtools/build/lib:foundations_testutil",
         "//src/test/java/com/google/devtools/build/lib:testutil",
         "//third_party:junit4",
         "//third_party:truth",

diff --git a/tools/test/LcovMerger/javatests/com/google/devtools/lcovmerger/LcovMergerTest.java b/tools/test/LcovMerger/javatests/com/google/devtools/lcovmerger/LcovMergerTest.java
@@ -18,7 +18,7 @@
 
 import com.google.devtools.build.lib.testutil.Scratch;
 import com.google.devtools.build.lib.vfs.FileSystemUtils;
-import com.google.devtools.build.lib.vfs.FileSystems;
+import com.google.devtools.build.lib.vfs.util.FileSystems;
 import java.io.File;
 import java.io.IOException;
 import java.nio.file.Files;
@@ -33,7 +33,7 @@
 public class LcovMergerTest {
 
   private final Scratch scratch =
-      new Scratch(FileSystemUtils.getWorkingDirectory(FileSystems.initDefaultAsJavaIo()));
+      new Scratch(FileSystemUtils.getWorkingDirectory(FileSystems.getJavaIoFileSystem()));
 
   @Test
   public void testZeroDatFile() throws IOException {