Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[8.0.0] fix: Fix trim_length in runfiles.bash (#24125)
`wc -c` has leading spaces that needs to be removed, otherwise trim_length would become ` 29` for example. ~I'm not very sure how test cases could work but this fails in our repo.~ I understand it now. We set `IFS=$'\\n\\t'` in our script, which makes this trick stops working `cut -b ${trim_length}-` (note that there are no quotes around `${trim_length}`. Although we could fix our `IFS`, this still seems to be a bug because it is not "portable". Closes #24076. PiperOrigin-RevId: 690707015 Change-Id: I728b7462994a6ffdb9b88c3cbea3ec044a8b0134 Commit bf666fb Co-authored-by: Honnix <[email protected]>
- Loading branch information