Skip to content

Commit

Permalink
Set use_default_shell_env for windows launcher maker action
Browse files Browse the repository at this point in the history
This is needed to inherit PATH when using non-MSVC compilers like MinGW

PiperOrigin-RevId: 519665645
Change-Id: Id8769bf3b7cf56efaf7ae3bfdde4e33f1744ff24
  • Loading branch information
hvadehra authored and copybara-github committed Mar 27, 2023
1 parent 165e768 commit 5a972e0
Showing 1 changed file with 2 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -338,6 +338,8 @@ def _create_windows_exe_launcher(
outputs = [output],
mnemonic = "PyBuildLauncher",
progress_message = "Creating launcher for %{label}",
# Needed to inherit PATH when using non-MSVC compilers like MinGW
use_default_shell_env = True,
)

def _create_zip_file(ctx, *, output, original_nonzip_executable, executable_for_zip_file, runfiles):
Expand Down

0 comments on commit 5a972e0

Please sign in to comment.