Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace Bazel Skylib's unittest.bzl with an alias to the version in rules_testing. #524

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Replace Bazel Skylib's unittest.bzl with an alias to the version in rules_testing. #524

wants to merge 6 commits into from

Conversation

susinmotion
Copy link

No description provided.

brandjon
brandjon reviewed Jun 11, 2024
View reviewed changes
Copy link
Member

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a lib/BUILD file with a bzl_library for unittest.bzl that also needs to be removed.

brandjon
brandjon requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests/BUILD has a target referencing unittest_test.sh, which I assume should go in rules_testing too.

brandjon
brandjon requested changes Jun 11, 2024
View reviewed changes
Copy link
Member

@brandjon brandjon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also tests/BUILD has a target referencing unittest_test.sh, which I assume should go in rules_testing too.

lib/unittest.bzl
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License header was truncated.

tests/BUILD Show resolved Hide resolved
BUILD Show resolved Hide resolved
@brandjon
Copy link
Member

Looks like there's a lib/BUILD file with a bzl_library for unittest.bzl that also needs to be removed.

Ignore, that was before I saw the file wasn't in fact deleted but updated to re-export / alias the new source-of-truth.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandjon brandjon brandjon requested changes

@tetromino tetromino Awaiting requested review from tetromino tetromino is a code owner

@comius comius Awaiting requested review from comius comius is a code owner

@hvadehra hvadehra Awaiting requested review from hvadehra hvadehra is a code owner

@c-mita c-mita Awaiting requested review from c-mita c-mita is a code owner

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@susinmotion @brandjon