Migrate for --incompatible_use_platforms_repo_for_constraints#214
Merged
laurentlb merged 1 commit intobazelbuild:masterfrom Oct 30, 2019
Merged
Migrate for --incompatible_use_platforms_repo_for_constraints#214laurentlb merged 1 commit intobazelbuild:masterfrom
laurentlb merged 1 commit intobazelbuild:masterfrom
Conversation
hlopko
requested review from
aiuto,
c-parsons,
jin and
laurentlb
as code owners
aiuto
approved these changes
Oct 29, 2019
aiuto
left a comment
aiuto
left a comment
There was a problem hiding this comment.
LGTM, but the tests are failing for resaons that seem entirely unrelated.
hlopko
force-pushed
the
migrate_incompatible_flags
branch
from
38c05d3 to
b10ce63
Compare
Member
Author
|
Well, not anymore after the rebase?! Weird. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bazelbuild/bazel#8622