Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add protoc-gen-validate 1.1.0 #3414

Closed
wants to merge 1 commit into from

Conversation

mering
Copy link
Contributor

@mering mering commented Dec 14, 2024

No description provided.

@bazel-io
Copy link
Member

Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (protoc-gen-validate) have been updated in this PR. Please review the changes.

@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@bazel-io skip_check unstable_url

@bazel-io bazel-io added the skip-url-stability-check Skip the URL stability check for the PR label Dec 14, 2024
@keith
Copy link
Member

keith commented Dec 14, 2024

ci failure

@mering mering force-pushed the protoc-gen-validate-1.1.0 branch from 5d13615 to afed944 Compare December 14, 2024 18:14
@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@keith can you trigger the CI again please?

@mering mering force-pushed the protoc-gen-validate-1.1.0 branch from afed944 to b5ddde1 Compare December 14, 2024 18:22
@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@keith one more time please

@mering
Copy link
Contributor Author

mering commented Dec 14, 2024

@keith Do you have an idea on how to break the dependency cycle?

@keith
Copy link
Member

keith commented Dec 14, 2024

i'd have to look deeper. i imagine there are some issues about it out there. i've been working on parts of this upstream, would be nice if we could land it there

@mering
Copy link
Contributor Author

mering commented Dec 16, 2024

Reported an issue in bazel-contrib/rules_go#4196.

@mering mering closed this Dec 20, 2024
@mering mering deleted the protoc-gen-validate-1.1.0 branch December 20, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip-url-stability-check Skip the URL stability check for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants