-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[email protected] #1866
[email protected] #1866
Conversation
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (com_github_benchsci_rules_nodejs_gazelle) have been updated in this PR. Please review the changes. |
Can you please rebase this PR to HEAD to get fixes from #1866? Also, is it intentional to call this module |
@meteorcloudy what will be the process of renaming the module |
Just change it in your MODULE.bazel file and the entry name used in this PR. |
fece532
to
4dd6f73
Compare
Hello @alexeagle, modules you maintain (aspect_rules_lint) have been updated in this PR. Please review the changes. |
Hello @dzbarsky, modules you maintain (aws-in-a-box) have been updated in this PR. Please review the changes. |
Hello @aherrmann, modules you maintain (rules_zig) have been updated in this PR. Please review the changes. |
Hello @morambro, modules you maintain (tink_cc) have been updated in this PR. Please review the changes. |
Hello @zadlg, modules you maintain (tree-sitter-c-bazel) have been updated in this PR. Please review the changes. |
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (bzip2, rules_nodejs_gazelle) have been updated in this PR. Please review the changes. |
4dd6f73
to
63fbd47
Compare
Hello @bazelbuild/bcr-maintainers, modules without existing maintainers (rules_nodejs_gazelle) have been updated in this PR. Please review the changes. |
b1d89f7
to
355c8d7
Compare
hi @meteorcloudy I am stuck with trying to rename the module Can you advice on how to fix this |
You have to fix https://github.com/benchsci/rules_nodejs_gazelle/blob/6542264ecb383191380918978d11b2ea3e8a450e/examples/nextjs/MODULE.bazel#L13-L17, which probably need a new patch release. |
4268244
to
588152d
Compare
@meteorcloudy we have decided to keep the original module name |
588152d
to
a121be6
Compare
Can you please check the windows failure? |
a121be6
to
816429e
Compare
@meteorcloudy can you please take a look |
@alexeagle @meteorcloudy can I please get this reviewed |
Sorry for the delays! Notifications in this repo has gotten a bit out of hand with all the C++ projects being added. |
Release: https://github.com/benchsci/rules_nodejs_gazelle/releases/tag/v0.7.0 _Automated by [Publish to BCR](https://github.com/apps/publish-to-bcr)_ Co-authored-by: Elvis M. Wianda <[email protected]>
Release: https://github.com/benchsci/rules_nodejs_gazelle/releases/tag/v0.7.0 _Automated by [Publish to BCR](https://github.com/apps/publish-to-bcr)_ Co-authored-by: Elvis M. Wianda <[email protected]>
Release: https://github.com/benchsci/rules_nodejs_gazelle/releases/tag/v0.7.0
Automated by Publish to BCR