-
-
Notifications
You must be signed in to change notification settings - Fork 637
chore: remove non-toolchain runtime resolution logic. #3280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- "If toolchains disabled" logic - `configuration_field` on `python_top` - `_py_interpreter` attribute For bazel-contrib#3252.
Summary of ChangesHello @gregestren, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request streamlines the Python runtime resolution mechanism by removing deprecated non-toolchain logic. It eliminates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request removes outdated non-toolchain resolution logic, which simplifies the codebase significantly. The changes correctly remove the _py_interpreter attribute and the conditional logic that depended on the use_toolchains flag. This is a good cleanup.
I've added one suggestion to improve the readability of the _maybe_get_runtime_from_ctx function by removing a redundant local variable.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Finding the Python runtime via toolchain resolution has been enabled by default for
many years. Toolchains are the preferred mechanism for specifying Python runtime info.
Usage of the non-toolchain ways should be approximately zero, and they'd be considered
unsupported anyways. Hence this is not considered a breaking change.
This PR removes support for
--incompatible_use_python_toolchains)configuration_fieldonpython_top(--python_topflag)_py_interpreterattribute (plumbing for python_top flag)Work towards #3252.