Skip to content

Conversation

@rickeylev
Copy link
Collaborator

We have the label, but it doesn't do anything. Add a workflow that can check it, to
be added as a required status check.

@rickeylev rickeylev requested a review from aignas as a code owner August 26, 2025 15:27
@rickeylev rickeylev requested review from dougthor42 and groodt August 26, 2025 15:28
@rickeylev
Copy link
Collaborator Author

Er, actually, I'll move this back to draft. I had an AI generate this, but didn't verify if it's correct. The on conditions look different than our other workflows, so I have to go crosscheck that.

@rickeylev rickeylev marked this pull request as draft August 26, 2025 15:30
@rickeylev rickeylev marked this pull request as ready for review August 27, 2025 07:55
@rickeylev
Copy link
Collaborator Author

Ok, consulted the docs. LGTM.

The difference between "pull_request" and "pull_request_target" is simply what code the action sees when it runs (post vs pre PR changes). Doesn't matter in this case, since it just cares about the PR state.

@rickeylev rickeylev added this pull request to the merge queue Aug 28, 2025
Merged via the queue into bazel-contrib:main with commit 365f30f Aug 28, 2025
3 checks passed
@rickeylev rickeylev deleted the feat/do-not-merge-check branch August 28, 2025 05:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants