fix: Fix bazel vendor support for requirements with environment markers #2997
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes `bazel vendor` support for requirements files that contain environment markers. During a vendored `bazel build`, when evaluate_markers_py() is run it needs PYTHONHOME set to properly find the home of the vendored libraries. Resolves (bazel-contrib#2996)
armandomontanez
requested review from
aignas,
groodt and
rickeylev
as code owners
aignas
reviewed
Jun 17, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
To make it possible to merge this it would be great if you could add a changelog note.
Any reason why you are using pip_parse instead of bzlmod example? It already is using the env markers.
| Label("@pypi__packaging//:BUILD.bazel"), | ||
| Label("//:BUILD.bazel"), | ||
| ], | ||
| "PYTHONHOME": str(interpreter.dirname), |
Contributor
Author
Done.
Ah, didn't realize that. Verified the |
aignas
approved these changes
Jun 22, 2025
Collaborator
aignas
left a comment
aignas
left a comment
There was a problem hiding this comment.
Moved the CI config up to be next to other examples/bzlmod invocations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
bazel vendorsupport for requirements files that contain environment markers. During a vendoredbazel build, when evaluate_markers_py() is run it needs PYTHONHOME set to properly find the home of the vendored libraries.Resolves #2996