Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: comma in entrypoint and cmd #663

Merged
merged 1 commit into from
Aug 7, 2024
Merged

Conversation

thesayyn
Copy link
Collaborator

Closes #659 and #631

Reason why i changed the delimiter from , to \n

  • Easier to create a file in a genrule, simply echo without the -n makes it work.
  • We no longer use crane so don't need to conform to their cmd and entrypoint must be a valid csv

@thesayyn thesayyn requested a review from alexeagle July 26, 2024 17:35
@thesayyn
Copy link
Collaborator Author

cc @mrmeku

@thesayyn thesayyn requested review from alexeagle and removed request for alexeagle August 4, 2024 17:32
oci/private/image.bzl Show resolved Hide resolved
@thesayyn thesayyn merged commit 9c50a4a into main Aug 7, 2024
18 checks passed
@thesayyn thesayyn deleted the fix_comma_cmd_entrypoint branch August 7, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2.0.0beta1: Entrypoints with comma separated values are not correctly built
2 participants