Add import_tags attribute to oci_pull #573
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds an import_tags attribute to the oci_pull macro to allow passing Bazel tags to the underlying rules. This implementation follows the naming and general implementation of the import_tags attribute on the old legacy container_pull rule.
|
the name import_tags is really confusing here. it's gonna be confused for Docker tags. |
|
And i belive the the |
The previous name, import_tags, was copied over from how rules_docker has it on the container_pull rule but this isn't the best name for the oci_pull macro as pointed out in the issue comment: bazel-contrib#573 (comment) > thesayyn: the name import_tags is really confusing here. it's gonna be > confused for Docker tags. > thesayyn: And i belive the the `import` is used here because > rules_docker used a rule called `container_import` under > the hood. So I change it to `bazel_tags` to indicate it is the bazel tags this is modifying.
|
ahh - good point. I made a change to rename |
thesayyn
reviewed
May 29, 2024
added 2 commits
May 30, 2024 18:18
On the oci_pull repository rule, the attribute passed in is renamed from "tags" -> "bazel_tags" to avoid confusion with container/docker tags. "bazel_tags" is now explicitly defined on the rule as an attribute. For the oci_alias repository rule, I removed the passed in attribute since it wasn't being used anywhere.
Ran bazel run @@//docs:update
thesayyn
approved these changes
May 30, 2024
alexeagle
pushed a commit
that referenced
this pull request
Jun 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an import_tags attribute to the oci_pull macro to allow passing Bazel tags to the underlying rules. This implementation follows the naming and general implementation of the import_tags attribute on the old legacy container_pull rule.
#572