-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: registryless oci_image #550
Conversation
88d4654
to
065b114
Compare
Did a quick test here. Everything builds/tests fine, but running an oci_tarball gives an error like this:
|
yeah, there's an unrelated change in this PR. thanks for the info! |
@mortenmj did you see any significant speed-up/slow-down, do you have an before-after? |
8d17c5f
to
2c1c3a2
Compare
Benchmark: distroless building all images |
de2d4f0
to
b1a71f4
Compare
Distroless all green! Breaking changes are observed here: GoogleContainerTools/distroless#1586 (comment) 🌮 |
cefe927
to
3036da8
Compare
f224682
to
0a67cc7
Compare
PTAL again, this is now ready. |
Great work! |
There seems to be an error in the description, which should be Maybe this generation refers to the compression options, but it is confusing. |
BREAKING CHANGES
tars
attribute is no longer compressed when creating the image, this might make images bigger compared to1.x
. Usepkg_tar#compression
ortar#compress
attribute to compress the layers beforehand.1.x
rules_oci will not match2.x
rules_oci, as we are no longer using crane to create the images. However, images should stay the same semantically.CHANGES
OCIImage
action no longer spins an ephemeral registry instance to mutate images locally, making it slightly faster.oci_image
now supportszstd
compressionCHECKLIST