Skip to content

Commit

Permalink
[docs] Add missing name to push examples (#513)
Browse files Browse the repository at this point in the history
  • Loading branch information
ptxmac authored Apr 22, 2024
1 parent e4ceef0 commit ee4220c
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 4 deletions.
6 changes: 4 additions & 2 deletions docs/push.md

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 4 additions & 2 deletions oci/private/push.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -22,12 +22,12 @@ Behavior
Pushing and tagging are performed sequentially which MAY lead to non-atomic pushes if one the following events occur;
- Remote registry rejects a tag due to various reasons. eg: forbidden characters, existing tags
- Remote registry rejects a tag due to various reasons. eg: forbidden characters, existing tags
- Remote registry closes the connection during the tagging
- Local network outages
In order to avoid incomplete pushes oci_push will push the image by its digest and then apply the `remote_tags` sequentially at
the remote registry.
the remote registry.
Any failure during pushing or tagging will be reported with non-zero exit code and cause remaining steps to be skipped.
Expand All @@ -53,6 +53,7 @@ Push an oci_image to docker registry with 'latest' tag
oci_image(name = "image")
oci_push(
name = "push",
image = ":image",
repository = "index.docker.io/<ORG>/image",
remote_tags = ["latest"]
Expand Down Expand Up @@ -89,6 +90,7 @@ expand_template(
)
oci_push(
name = "push",
image = ":app_image",
repository = "ghcr.io/<OWNER>/image",
remote_tags = ":stamped",
Expand Down

0 comments on commit ee4220c

Please sign in to comment.