chore(6.0): move providers to build_bazel_rules_nodejs #3652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
reviewed
Apr 4, 2023
There was a problem hiding this comment.
Yeah, the original intent of rules_nodejs bazel module was to include both the toolchain and the interop providers, but later in rules_js development @gregmagolan decided to have all the providers in rules_js. I think it's worth one more discussion of whether any of those providers could be in rules_nodejs.
We will delete build_bazel_rules_nodejs before 6.0 so assuming we don't want to allow interop between JS rules, I think we just delete these.
alexeagle
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think they belong in
build_bazel_rules_nodejssincerules_nodejsdoesn't use them?