Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade typescript, add ts_project angular test #2625

Merged
merged 3 commits into from
Apr 27, 2021

Conversation

jbedard
Copy link
Collaborator

@jbedard jbedard commented Apr 23, 2021

I wanted to test a modern version of angular which includes angular/angular#36290, that requires a modern version of typescript. I can move that to a separate PR if wanted.

Main goal was adding a ts_project(tsc=ngc) test. When enabling workers something goes wrong, it seems like ngc is no longer used and it uses tsc in the worker. That will be next... either a bug fix or disable workers if a custom tsc is passed in as a quick solution?

@jbedard jbedard requested a review from alexeagle April 23, 2021 19:50
@google-cla google-cla bot added the cla: yes label Apr 23, 2021
@jbedard jbedard force-pushed the ts_project-angular-test branch 3 times, most recently from c257fbf to 5a3c36a Compare April 23, 2021 21:36
@@ -11,18 +9,33 @@ function _interopDefaultLegacy (e) { return e && typeof e === 'object' && 'defau
var path__default = /*#__PURE__*/_interopDefaultLegacy(path);
var fs__default = /*#__PURE__*/_interopDefaultLegacy(fs);

function getDefaultExportFromCjs (x) {
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the only file where the diff seems odd 🤔

getDefaultExportFromCjs is a rollup method, not typescript... why would a typescript update cause this?

and some of this just looks odd, like doing the defineProperty(exports, "__esModule" twice 🤔

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's possible and reasonable that rollup does something different when it sees the changed output from TypeScript that resulted from microsoft/TypeScript#37093

Like there is now a default export from this file and wasn't before? https://github.com/bazelbuild/rules_nodejs/blob/stable/packages/runfiles/index.ts

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aeagle@aeagle-a01 rules_nodejs % diff dist/bin/packages/runfiles/index.js /tmp/index.js
2a3
> exports.runfiles = exports._BAZEL_OUT_REGEX = exports.Runfiles = void 0;
4c5
< exports.Runfiles = runfiles_1.Runfiles;
---
> Object.defineProperty(exports, "Runfiles", { enumerable: true, get: function () { return runfiles_1.Runfiles; } });
6c7
< exports._BAZEL_OUT_REGEX = paths_1.BAZEL_OUT_REGEX;
---
> Object.defineProperty(exports, "_BAZEL_OUT_REGEX", { enumerable: true, get: function () { return paths_1.BAZEL_OUT_REGEX; } });

@google-cla
Copy link

google-cla bot commented Apr 27, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 27, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@google-cla
Copy link

google-cla bot commented Apr 27, 2021

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@alexeagle
Copy link
Collaborator

@googlebot I consent.

@google-cla google-cla bot added cla: yes and removed cla: no labels Apr 27, 2021
@alexeagle alexeagle merged commit 6241f16 into bazel-contrib:stable Apr 27, 2021
twheys pushed a commit to twheys/rules_nodejs that referenced this pull request Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants