chore: remove install_bazel_dependencies #2337
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrmeku
requested review from
alexeagle,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
reviewed
Dec 8, 2020
| - "//internal/npm_install/test:index" | ||
| # Disabled due to https://github.com/bazelbuild/rules_nodejs/issues/1486 | ||
| #- "@fine_grained_deps_yarn//typescript/bin:tsc" | ||
| - "@bazel_workspace_a//:bin" |
Collaborator
There was a problem hiding this comment.
my only concern is that these tests might be giving us coverage for something. Maybe we can update them to not rely on install_bazel_dependencies? ppl should still be able to ship npm packages that include bazel rules
Collaborator
There was a problem hiding this comment.
I patched the change locally to try that out and understand it better. These nested workspaces are specifically testing the package.json bazelWorkspaces install-as-separate-repository feature that's being removed here, so I think what you have is correct ;)
alexeagle
approved these changes
Dec 8, 2020
Collaborator
|
🍕 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1877