Remove jasmine-core as a peer dep for @bazel/concatjs #2336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattem
force-pushed
the
fix/jasmine-peer-dep
branch
2 times, most recently
from
1250d19 to
6b27e86
Compare
mattem
requested review from
alan-agius4,
alexeagle,
gregmagolan,
mrmeku and
soldair
as code owners
gregmagolan
reviewed
Dec 9, 2020
gregmagolan
approved these changes
Dec 9, 2020
mattem
force-pushed
the
fix/jasmine-peer-dep
branch
from
6b27e86 to
b07ae56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove the
jasmine-corepeer dep from@bazel/concatjs. This PR also removes it from the examples that don't use@bazel/jasmineto test that it's not load bearing.With
strict_visibilityenabled now by default, previously this would have caused bazel visibility errors.