refactor: rename ts_devserver to concatjs_devserver and move to @baze… #2239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
requested review from
alan-agius4,
gregmagolan,
mattem and
soldair
as code owners
alexeagle
force-pushed
the
concatjs_devserver
branch
from
b152ed6 to
9458e3e
Compare
mattem
reviewed
Oct 18, 2020
| This is intentionally very simple, to help you get started quickly. However, | ||
| since there are many development servers available, we do not want to mirror | ||
| their features in yet another server we maintain. | ||
| 1. Teach your real frontend server to serve files from Bazel's output directory. |
Collaborator
Author
There was a problem hiding this comment.
well this is valid markdown too, but yeah if you're reading source it's nice not to have to render markdown in your head :)
Comment on lines
+32
to
+33
| So Bazel rules that originated in Google's codebase, such as `ts_library` depend in some ways on producing concatjs output. | ||
|
|
Collaborator
There was a problem hiding this comment.
I think it's worth mentioning the karma rules also use concatjs, unless that's already in here and I missed it
Collaborator
Author
There was a problem hiding this comment.
Actually I think I'll send another PR to move karma_web_test but it needs a bit more thought. Will add a note here for now
…ncatjs BREAKING CHANGE: users need to change their load statements for ts_devserver Fixes bazel-contrib#1082
alexeagle
force-pushed
the
concatjs_devserver
branch
from
9458e3e to
325f438
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l/concatjs
BREAKING CHANGE:
users need to change their load statements for ts_devserver
Fixes #1082