refactor: warn on install_bazel_dependencies #1921
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexeagle
force-pushed
the
rm_install_bazel_deps
branch
from
b45800c to
db0a169
Compare
alexeagle
force-pushed
the
rm_install_bazel_deps
branch
from
db0a169 to
552c954
Compare
alexeagle
changed the title
This function is no longer needed since bazel-contrib#1149 was finished. However, @angular/bazel relies on it, as might other third-party packages we know nothing about. The conservative rollout is to warn on usage for now, then remove the feature in 3.0 This change also removes our own usage of the function except for angular_view_engine. We also stop writing it in new workspaces created with @bazel/create
alexeagle
force-pushed
the
rm_install_bazel_deps
branch
from
552c954 to
37d7fd7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was causing npm install on all builds, even if they didn't need it for the requested output artifacts
BREAKING CHANGE:
Remove install_bazel_dependencies from your WORKSPACE file, it is no longer needed