-
-
Notifications
You must be signed in to change notification settings - Fork 248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix coursier credentials #700
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). For more information, open the CLA check for this pull request. |
fdd6da4
to
79a2a91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch. Thank you for the PR. The CI tests that are failing look related, but once they pass, I'll be happy to merge this :)
Sorry for the slow response to your initial PR --- I missed this in my reviews, and only just saw it. I appreciate your patience! |
5d850d6
to
7190473
Compare
7190473
to
fa1b0c8
Compare
fixed the offending test. The current failures don't seem to be relevant? |
@lgzy can you rebase this PR on latest master? |
I believe this was fixed with #721 ? |
Changes
_repository_credentials
to return a string surrounded with quotes as the result is passed to commandline as one of parameters in the form of... --credentials <result string>
and ends up being incorrectly parsed. The quotes enable it to be correctly parsed.