Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Rules license support #683

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

danielmachlab
Copy link
Contributor

@danielmachlab danielmachlab commented Apr 21, 2022

This change updates maven_install to accept a JSON file with license metadata, so it can then generate rule_license license instances in the BUILD file it creates. In the BUILD file, maven_install will use the applicable_licenses global attribute to apply the licenses to the artifacts.

See an example usage of this feature here: bazelbuild/rules_license#35

Design doc: https://docs.google.com/document/d/1XnDEQArn_hAIiExSHPgo8v2UZWP3eRf0OtUldLuHso8/edit#

@Bencodes
Copy link
Contributor

@danielmachlab are you still planning on merging this? This is something that we'd like to use internally.

@danielmachlab
Copy link
Contributor Author

@Bencodes although this works, it was an initial design and we are now working on an alternate approach as described here and here. However, we'd love if you joined our SIG meeting on Monday, August 22nd to discuss this solution and others that might work for Lyft—here is the calendar invitation.

@davidkurkov
Copy link
Contributor

@danielmachlab , I'd be interested in joining the meeting to discuss. The calendar invite link doesn't appear to be working, is there another link I can follow to see when/how to join?

@danielmachlab
Copy link
Contributor Author

danielmachlab commented Aug 22, 2022

@davidkurkov it would be great to have you join. We are meeting today at 3pm ET here: https://meet.google.com/hzf-xdih-vpt

@davidkurkov
Copy link
Contributor

Awesome, thanks @danielmachlab !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants