Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ivy repo support #515

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Ivy repo support #515

wants to merge 2 commits into from

Conversation

khogeland
Copy link

@khogeland khogeland commented Feb 1, 2021

Coursier supports Ivy repo patterns, and this almost works out-of-the-box with these rules, but I ran into one place that needs special handling.

@google-cla
Copy link

google-cla bot commented Feb 1, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

1 similar comment
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

1 similar comment
@google-cla
Copy link

google-cla bot commented Feb 1, 2021

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added cla: yes and removed cla: no labels Feb 1, 2021
@jin
Copy link
Collaborator

jin commented Feb 2, 2021

Thank you for your PR! Please add tests to demonstrate that this works with the features we have in rules_jvm_external today, especially with integration tests (see the root WORKSPACE file).

@khogeland
Copy link
Author

@jin I added a test to verify maven_install will resolve Ivy artifacts and their dependencies, is that sufficient? I'm not sure what features you're referring to.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants