Detect when pinned inputs have changed and stop the build #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheister
reviewed
Jan 10, 2021
cheister
reviewed
Jan 10, 2021
cheister
reviewed
Jan 10, 2021
cheister
reviewed
Jan 10, 2021
jin
approved these changes
Jan 19, 2021
Optionally force people to repin if the inputs to maven_install have changed. This is done by adding a new `fail_if_repin_required` attribute to `maven_install`. In order to preserve existing behaviour, this is currently set to `False`, but users can update to `True` if required. If a repin is not required, a warning is printed to the console and the build continues as expected. If a repin is required, the build is failed and steps to rectify the situation are printed. In addition to the `maven_install` attribute the `REPIN` environment variable is checked. This allows one to update the inputs without needing to modify the `WORKSPACE` file.
shs96c
force-pushed
the
require-repin
branch
from
9c82810 to
ba12849
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optionally force people to repin if the inputs to maven_install have
changed. This is done by adding a new
fail_if_repin_requiredattribute to
maven_install. In order to preserve existing behaviour,this is currently set to
False, but users can update toTrueifrequired.
If a repin is not required, a warning is printed to the console and
the build continues as expected. If a repin is required, the build is
failed and steps to rectify the situation are printed.
In addition to the
maven_installattribute theREPINenvironment variable is checked. This allows one to update the inputs
without needing to modify the
WORKSPACEfile.