Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no-remote-cache tags to intermediate artifacts so rules_jvm_external works with --remote_download_toplevel set #1033

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cheister
Copy link
Collaborator

When updating to Bazel 7.0.0 the default Build without the Bytes (BwoB) setting goes from --remote_download_all to --remote_download_toplevel. For our build, this started breaking the intermediate jars used by rules_jvm_external and we had to go back to --remote_download_all to have them work. In our case, if we did a bazel clean then a bazel build it would not find the intermediate jar targets used by rules_jvm_external.

This change fixes rules_jvm_external when --remote_download_toplevel is set but I'm not sure if this is the correct fix or not. I'm looking for input if there might be another way to keep it working. Bazel common cache tags reference is here

…nal works with --remote_download_toplevel set
@shs96c
Copy link
Collaborator

shs96c commented Jan 15, 2024

Gently pushing back on this. We've been using BwoB at work for some time, and haven't seen this problem.

Is this happening on the command line builds? Or somewhere else (perhaps in the IDE integration?) Normally, you won't need to download intermediate artifacts, but perhaps you're doing something after the build that needs them?

Would the remote_download_regex in your project repo be sufficient?

@cheister
Copy link
Collaborator Author

Is this happening on the command line builds? Or somewhere else (perhaps in the IDE integration?) Normally, you won't need to download intermediate artifacts, but perhaps you're doing something after the build that needs them?

This is all command line. I'll keep looking, I'm not sure what would need these intermediate artifacts in the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants