-
-
Notifications
You must be signed in to change notification settings - Fork 760
Go vet rule #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Go vet rule #735
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| # Copyright 2014 The Bazel Authors. All rights reserved. | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| load("@io_bazel_rules_go//go/private:providers.bzl", "GoPath") | ||
| load("@io_bazel_rules_go//go/private:common.bzl", "get_go_toolchain") | ||
|
|
||
| def _go_vet_generate_impl(ctx): | ||
| print(""" | ||
| EXPERIMENTAL: the go_vet_test rule is still very experimental | ||
| Please do not rely on it for production use, but feel free to use it and file issues | ||
| """) | ||
| go_toolchain = get_go_toolchain(ctx) | ||
| script_file = ctx.new_file(ctx.label.name+".bash") | ||
| gopath = [] | ||
| files = ctx.files.data | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In #726, they copied lists from
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Changed |
||
| files += [go_toolchain.go] | ||
| gopath = [] | ||
| packages = [] | ||
| for data in ctx.attr.data: | ||
| entry = data[GoPath] | ||
| gopath += [entry.gopath] | ||
| packages += [package.dir for package in entry.packages] | ||
| ctx.file_action(output=script_file, executable=True, content=""" | ||
| export GOROOT="{goroot}" | ||
| export GOPATH={gopath} | ||
| {go} tool vet {packages} | ||
| """.format( | ||
| go=go_toolchain.go.path, | ||
| goroot=go_toolchain.root.path, | ||
| gopath=":".join(['$(realpath "{}")'.format(entry) for entry in gopath]), | ||
| packages=" ".join(packages), | ||
| )) | ||
| return struct( | ||
| files = depset([script_file]), | ||
| runfiles = ctx.runfiles(files, collect_data = True), | ||
| ) | ||
|
|
||
| _go_vet_generate = rule( | ||
| _go_vet_generate_impl, | ||
| attrs = { | ||
| "data": attr.label_list(providers=[GoPath], cfg = "data"), | ||
| "_go_toolchain": attr.label(default = Label("@io_bazel_rules_go_toolchain//:go_toolchain")), | ||
| }, | ||
| ) | ||
|
|
||
| def go_vet_test(name, data, **kwargs): | ||
| script_name = "generate_"+name | ||
| _go_vet_generate( | ||
| name=script_name, | ||
| data=data, | ||
| tags = ["manual"], | ||
| ) | ||
| native.sh_test( | ||
| name=name, | ||
| srcs=[script_name], | ||
| data=data, | ||
| **kwargs | ||
| ) | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/2014/2017/
Will
go_fmt_testandgo_fix_testalso be in this file in the future? tools.bzl is an unfortunately generic name, even though it is accurate. Maybe go_tools.bzl or tool_tests.bzl would be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not all things would be tests.
I was going to stick all the tools in one file, but how about this structure, a tools directory with a bzl file per tool, so go/private/tools/vet.bzl